Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: node liveness records shouldn't use MVCC #37708

Open
andreimatei opened this issue May 21, 2019 · 6 comments
Open

storage: node liveness records shouldn't use MVCC #37708

andreimatei opened this issue May 21, 2019 · 6 comments
Labels
A-kv Anything in KV that doesn't belong in a more specific category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects

Comments

@andreimatei
Copy link
Contributor

andreimatei commented May 21, 2019

These records currently use MVCC, but that seems ridiculous. We're wasting space and causing splits in a sensitive region of the key space.
I think we should move away from MVCC, but I'm not entirely sure about how the migration would work. @tbg have you ever thought about this?

I've also found this random note that wants the liveness record key prefix changed, which perhaps could be done at the same time.
#18276 (comment)

cc @nvanbenschoten

Jira issue: CRDB-4421

@andreimatei andreimatei added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv Anything in KV that doesn't belong in a more specific category. labels May 21, 2019
@andreimatei andreimatei added this to Incoming in KV via automation May 21, 2019
@tbg
Copy link
Member

tbg commented May 21, 2019

I agree that MVCC isn't useful here. My expectation is that we'll move away from node liveness (for example to @andy-kimball's proposed failure detector) and that it won't be worth it to do something in the interim (was this issue motivated by something, for example a stability problem? I know we've had some in the past, but thought we had successfully worked around them for now).
Which splits do you mean? The liveness range itself can't be split.

@andreimatei
Copy link
Contributor Author

was this issue motivated by something, for example a stability problem?

No, it wasn't motivated by anything in particular.

Which splits do you mean? The liveness range itself can't be split.

I was actually wondering about that. I thought it wouldn't, but then I couldn't find what prevents it. Now I did.

@lunevalex lunevalex moved this from Incoming to Replication in KV Jul 15, 2020
@lunevalex lunevalex moved this from Replication to Cold storage in KV Apr 23, 2021
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@knz
Copy link
Contributor

knz commented Jun 5, 2021

definitely still relevant

@jlinder jlinder added the T-kv KV Team label Jun 16, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@knz
Copy link
Contributor

knz commented Sep 20, 2023

cc @andrewbaptist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv Anything in KV that doesn't belong in a more specific category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
KV
On Hold
Development

No branches or pull requests

4 participants