Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: graceful shutdown of server #40

Closed
andybons opened this issue Sep 3, 2014 · 4 comments
Closed

http: graceful shutdown of server #40

andybons opened this issue Sep 3, 2014 · 4 comments
Labels
help wanted Help is requested / needed by the one who filed the issue to fix it.

Comments

@andybons
Copy link
Contributor

andybons commented Sep 3, 2014

From: https://code.google.com/p/go/issues/detail?id=4674:

Status update: Go 1.3 will have all the necessary net/http changes (Server.ConnState and
Server.SetKeepAlivesEnabled) for other people to implement graceful shutdown properly,
outside the net/http package.

Go 1.3 is out and we are compiling against it. We should shut down the servers gracefully.

Take a look at func (s *server) stop() in server/server.go

@andybons
Copy link
Contributor Author

andybons commented Sep 3, 2014

Also some goodness from this thread: https://groups.google.com/forum/#!topic/golang-nuts/vLHWa5sHnCE

@andybons
Copy link
Contributor Author

andybons commented Dec 6, 2014

@spencerkimball
Copy link
Member

httpdown looks pretty damn good. Reminds me that I wrote the same code for GSE back in 2002.

@spencerkimball
Copy link
Member

Closed by #636

soniabhishek pushed a commit to soniabhishek/cockroach that referenced this issue Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Help is requested / needed by the one who filed the issue to fix it.
Projects
None yet
Development

No branches or pull requests

2 participants