Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove --dev mode #4352

Closed
petermattis opened this issue Feb 12, 2016 · 4 comments
Closed

cli: remove --dev mode #4352

petermattis opened this issue Feb 12, 2016 · 4 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Milestone

Comments

@petermattis
Copy link
Collaborator

Once #4269 goes in, the only remaining reason for --dev mode is to automatically configure a memory store. I think we should encourage developers (primarily ourselves) to use a disk store instead. See also #4335. Using a disk store during ad-hoc testing is closer to how cockroach will be used in production and will possibly reveal bugs that are not present when always starting from a clean slate.

@tamird
Copy link
Contributor

tamird commented Feb 12, 2016

There is at least one other reason for --dev which I proposed here.

@petermattis
Copy link
Collaborator Author

The discussion in #4269 proposes to make listening on only localhost the default unless --insecure or --{cert,key}-file are specified. I think that covers your proposed usage. Effectively, the lack of --insecure or --{cert,key}-file causes a server to be in dev-mode.

@tamird
Copy link
Contributor

tamird commented Feb 12, 2016

OK, I think that can work.

@petermattis petermattis added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 14, 2016
@petermattis petermattis modified the milestone: Beta Feb 14, 2016
@petermattis
Copy link
Collaborator Author

Fixed by #4453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

3 participants