Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql,server: enable client connections to time out #44012

Closed
knz opened this issue Jan 15, 2020 · 0 comments · Fixed by #44022
Closed

sql,server: enable client connections to time out #44012

knz opened this issue Jan 15, 2020 · 0 comments · Fixed by #44022
Assignees
@knz
Labels
A-kv-server Relating to the KV-level RPC server A-security A-sql-pgwire pgwire protocol issues. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@knz
Copy link
Contributor

knz commented Jan 15, 2020

Currently if some system ranges are unavailable, cockroachdb waits forever for a query on system.user to complete before it authenticates a client.

Client libraries with a built-in timeout are fine, but those that haven't are out of luck, potentially causing an accumulation of TCP sockets in the system in state accepted, but not making progress.

CockroachDB should instead have a timeout after which it refuses the connection, and the timeout should be configurable.
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgwire pgwire protocol issues. A-kv-server Relating to the KV-level RPC server A-security labels Jan 15, 2020
@knz knz added this to To do in DB Server & Security via automation Jan 15, 2020
@knz knz self-assigned this Jan 15, 2020
@knz knz mentioned this issue Jan 15, 2020
Merged
@knz knz moved this from To do to In progress in DB Server & Security Jan 16, 2020
@craig craig bot closed this as completed in 13af75f Jan 17, 2020
DB Server & Security automation moved this from In progress to Done 20.1 Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-kv-server Relating to the KV-level RPC server A-security A-sql-pgwire pgwire protocol issues. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server,sql,pgwire: let client conns timeout on unavailable clusters knz/cockroach
1 participant
@knz