Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colexec: support CASE operator with Bytes output type #44700

Closed
yuzefovich opened this issue Feb 4, 2020 · 0 comments · Fixed by #66399
Closed

colexec: support CASE operator with Bytes output type #44700

yuzefovich opened this issue Feb 4, 2020 · 0 comments · Fixed by #66399
Assignees
@yuzefovich
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries

Comments

@yuzefovich
Copy link
Member

When #44660 merges, we will have disabled planning of CASE operator with Bytes as an output type due to current contradiction between the way CASE operator populates its output (setting values in arbitrary order) and flat bytes that prohibit sets in arbitrary order.

We should fix it. Probably the way to go is to refactor CASE operator to not be so tricky with selection vectors, and, instead, copy the data to select tuples out. This will allows us to remove SelOnDest flag from coldata.CopySliceArgs as well.
@yuzefovich yuzefovich added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Feb 4, 2020
@yuzefovich yuzefovich added this to Triage in BACKLOG, NO NEW ISSUES: SQL Execution via automation Feb 4, 2020
@asubiotto asubiotto moved this from Triage to [BACKLOG] Bugs/Test Failures in BACKLOG, NO NEW ISSUES: SQL Execution Feb 4, 2020
@yuzefovich yuzefovich self-assigned this Jun 12, 2021
@yuzefovich yuzefovich added this to Triage in SQL Queries via automation Jun 12, 2021
@yuzefovich yuzefovich moved this from Triage to 21.2 June Milestone in SQL Queries Jun 12, 2021
@yuzefovich yuzefovich mentioned this issue Jun 12, 2021
Merged
@yuzefovich yuzefovich removed this from [VECTORIZED BACKLOG] Bugs/Test Failures in BACKLOG, NO NEW ISSUES: SQL Execution Jun 12, 2021
@jlinder jlinder added the T-sql-queries SQL Queries Team label Jun 16, 2021
@mgartner mgartner moved this from 21.2 June Milestone to 21.2 July Milestone in SQL Queries Jul 15, 2021
@craig craig bot closed this as completed in 5a5b3dc Jul 16, 2021
SQL Queries automation moved this from 21.2 July Milestone to Done Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
SQL Queries
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

colexec: refactor CASE operator to support all types yuzefovich/cockroach
2 participants
@jlinder @yuzefovich