sql: overflow during Encode during insert of large interval

[jordanlewis]

The following scenario demonstrates an unusual error:

root@127.0.0.1:55413/defaultdb> create table a (a interval);
CREATE TABLE
root@127.0.0.1:58949/defaultdb> select '40000y'::interval;
   interval
---------------
  40000 years
(1 row)
root@127.0.0.1:55413/defaultdb> insert into a select '40000y'::interval;
ERROR: overflow during Encode
SQLSTATE: 22015

I'd expect this to not fail, or fail in a saner way. Might relate to #26932.

Jira issue: CRDB-5110

[jordanlewis]

@rohany could you take a quick look at this please?

[rohany]

Based on

	// Used in overflow calculations.
	maxYearsInDuration = math.MaxInt64 / nanosInMonth
	minYearsInDuration = math.MinInt64 / nanosInMonth

in pkg/util/duration/duration.go, the max amount of years in a duration is 3558. Since this is larger, it throws an error. We could improve the message though.

[jordanlewis]

Should select '40000y'::interval; be allowed? It works fine at the moment...

[rohany]

We don't have to encode the interval in that case though, so I guess it works.

[jordanlewis]

It works, but... should it be allowed!

[rohany]

Hmm, it seems to me more like a limitation with how we encode intervals (using 3 ints). Perhaps a new encoding scheme wouldn't have these limitations.

[mgartner]

This is related to #84078.