Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/_status/vars is world readable #50126

Closed
korpa opened this issue Jun 11, 2020 · 6 comments
Closed

/_status/vars is world readable #50126

korpa opened this issue Jun 11, 2020 · 6 comments
Assignees
Labels
A-docs A-security A-webui-security C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-community Originated from the community

Comments

@korpa
Copy link

korpa commented Jun 11, 2020

Describe the problem

Spin up a secure cluster with cli parameters

  • --certs-dir=
  • --advertise-addr=
  • --join=
  • --cache=
  • --max-sql-memory=

To Reproduce

goto https://[ip]:8080/_status/vars

Expected behavior

  • Endpoint is only accessable via authentication like basic-auth
    or
  • A cli parameter e.g. --activate-status-vars=true is needed to activate it
    or
  • At least a warning on https://www.cockroachlabs.com/docs/stable/security-overview.html that this endpoint is exposed to the world and a http proxy to secure this endpoint is needed.

Additional data / screenshots

Environment:

  • CockroachDB version 20.1

Additional context

@blathers-crl
Copy link

blathers-crl bot commented Jun 11, 2020

Hello, I am Blathers. I am here to help you get the issue triaged.

Hoot - a bug! Though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here.

I have CC'd a few people who may be able to assist you:

If we have not gotten back to your issue within a few business days, you can try the following:

  • Join our community slack channel and ask on #cockroachdb.
  • Try find someone from here if you know they worked closely on the area and CC them.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Jun 11, 2020
@solongordon
Copy link
Contributor

@knz Sending this your way since I know you addressed similar security concerns in v20.1. Was this endpoint ever discussed during that work?

@knz
Copy link
Contributor

knz commented Jun 15, 2020

Yes it was considered that the information exposed this way was not sensitive.

@korpa FYI there are multiple HTTP endpoints that are similarly world-readable. We always recommend suitable proxying / firewalling for best security.

@knz knz added this to To do in DB Server & Security via automation Jun 15, 2020
@korpa
Copy link
Author

korpa commented Jun 16, 2020

@knz
Copy link
Contributor

knz commented Jun 16, 2020

@taroface can you lift this issue into a doc project?

@knz
Copy link
Contributor

knz commented Jul 30, 2020

Superseded by #50472

@knz knz closed this as completed Jul 30, 2020
DB Server & Security automation moved this from To do to Done 20.2 Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs A-security A-webui-security C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-community Originated from the community
Projects
None yet
Development

No branches or pull requests

3 participants