Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: update bash and zsh completions #50187

Closed
knz opened this issue Jun 14, 2020 · 0 comments · Fixed by #63839
Closed

cli: update bash and zsh completions #50187

knz opened this issue Jun 14, 2020 · 0 comments · Fixed by #63839
Labels
A-cli-flags Pertains to CLI flag handling common to all CLI commands C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
SQL CLI (demo + sql + workload + dump)

Comments

@knz
Copy link
Contributor

knz commented Jun 14, 2020

We're updating the cobra dependency in #50148.

The new code has much enhanced support for bash and zsh completions. We should lift the cockroachdb commands that generate these completions to use the new code.
@knz knz added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-cli labels Jun 14, 2020
@knz knz added A-cli-flags Pertains to CLI flag handling common to all CLI commands and removed A-cli labels Mar 20, 2021
@knz knz mentioned this issue Apr 19, 2021
Merged
@craig craig bot closed this as completed in 0609f89 Apr 19, 2021
@craig craig bot closed this as completed in #63839 Apr 19, 2021
SQL CLI (demo + sql + workload + dump) automation moved this from To do to Done Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli-flags Pertains to CLI flag handling common to all CLI commands C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
SQL CLI (demo + sql + workload + dump)
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: bump the cobra dependency and add autocompletion for fish knz/cockroach
1 participant
@knz