Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: simplify logic in updater for delete only indexes #52551

Open
mgartner opened this issue Aug 10, 2020 · 1 comment
Open

sql: simplify logic in updater for delete only indexes #52551

mgartner opened this issue Aug 10, 2020 · 1 comment
Labels
A-partial-indexes Relating to partial indexes. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
SQL Queries

Comments

@mgartner
Copy link
Collaborator

mgartner commented Aug 10, 2020 •
edited by cockroach-jira-scripts

Context: https://reviewable.io/reviews/cockroachdb/cockroach/50950#-MBH2fiuEo835LNztY7s

This code and the TODO should be able be able to be simplified by adding delete-only indexes to the PartialIndexUpdateHelper.

Jira issue: CRDB-3940
@mgartner mgartner added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-partial-indexes Relating to partial indexes. labels Aug 10, 2020
@mgartner mgartner self-assigned this Aug 10, 2020
@mgartner mgartner added this to To Do in Partial Indexes via automation Aug 10, 2020
@mgartner mgartner moved this from To Do to In Progress in Partial Indexes Aug 15, 2020
@mgartner
Copy link
Collaborator Author

I spent some time trying to do this but ran into a few things:

  1. We can't use the PartialIndexUpdateHelper because that is dependent on each row being updated. But we can use a separate util.FastIntSet to keep track of the delete-only indexes, and check that here.

  2. We'll need to fetch columns referenced in the delete-only indexes in order to build entries to delete. Notice this comment.

@mgartner mgartner moved this from In Progress to To Do in Partial Indexes Aug 15, 2020
@mgartner mgartner changed the title sql: use partial index update helper to updateddelete only indexes sql: simplify logic in updater for delete only indexes Aug 28, 2020
@mgartner mgartner removed their assignment Sep 1, 2020
@mgartner mgartner removed this from To Do in Partial Indexes Feb 16, 2023
@mgartner mgartner added this to Triage in SQL Queries via automation Feb 16, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Feb 16, 2023
@mgartner mgartner moved this from Triage to Backlog in SQL Queries Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-partial-indexes Relating to partial indexes. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Backlog
SQL Queries
Backlog (DO NOT ADD NEW ISSUES)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgartner