Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: PROSCRIBED lease cannot be replaced immediately after restart #59874

Open
nvanbenschoten opened this issue Feb 5, 2021 · 1 comment
Open
Assignees
Labels
A-kv-transactions Relating to MVCC and the transactional model. A-leader-leases Related to the introduction of leader leases C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team T-multiregion

Comments

@nvanbenschoten
Copy link
Member

nvanbenschoten commented Feb 5, 2021

Now that leaseholders can serve reads in the future of their clock time but below their lease's expiration time, we need to be more careful about when we replace leases after a restart. We currently prevent a leaseholder from re-using its lease after a restart (when it would have lost its timestamp cache), but we allow the leaseholder to immediately re-acquire a lease (with a new start time). This is no longer sufficient to ensure that the new lease doesn't serve writes that violate reads served under the old lease. Instead, we now need to prevent a new lease from beginning until after the old lease expires.

Jira issue: CRDB-3218

@nvanbenschoten nvanbenschoten added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-transactions Relating to MVCC and the transactional model. labels Feb 5, 2021
@nvanbenschoten nvanbenschoten self-assigned this Feb 5, 2021
@nvanbenschoten nvanbenschoten added this to To be considered in KV 21.1 Stability Period via automation Feb 23, 2021
@nvanbenschoten nvanbenschoten moved this from To be considered to STABILITY PERIOD in KV 21.1 Stability Period Feb 23, 2021
@tbg tbg added this to Incoming in KV via automation Mar 23, 2021
@lunevalex lunevalex moved this from Incoming to On Hold in KV Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@nvanbenschoten nvanbenschoten added the A-leader-leases Related to the introduction of leader leases label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-transactions Relating to MVCC and the transactional model. A-leader-leases Related to the introduction of leader leases C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team T-multiregion
Projects
KV
On Hold
KV 21.1 Stability Period
Old (to be moved to KV Backlog)
Development

No branches or pull requests

2 participants