Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add sampled execution statistics to node_{statement,transaction}_statistics #61637

Closed
asubiotto opened this issue Mar 8, 2021 · 1 comment · Fixed by #62006
Closed

sql: add sampled execution statistics to node_{statement,transaction}_statistics #61637

asubiotto opened this issue Mar 8, 2021 · 1 comment · Fixed by #62006
Assignees
@asubiotto
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@asubiotto
Copy link
Contributor

We record sampled execution stats in stmtStats and txnStats to be sent to the DB Console. These execution stats should also be accessible via our statement/transaction statistics virtual tables.
@asubiotto asubiotto added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Mar 8, 2021
@asubiotto asubiotto added this to Triage in BACKLOG, NO NEW ISSUES: SQL Execution via automation Mar 8, 2021
@asubiotto
Copy link
Contributor Author

If we haven't collected any, the columns should probably show a -1 value or something to make it clear (maybe a NULL value makes more sense) that the values are invalid

@asubiotto asubiotto added this to Triage in Cluster Observability via automation Mar 8, 2021
@asubiotto asubiotto moved this from Triage to Possible Starter Projects in Cluster Observability Mar 8, 2021
@asubiotto asubiotto mentioned this issue Mar 9, 2021
Closed
@asubiotto asubiotto self-assigned this Mar 9, 2021
@asubiotto asubiotto moved this from Triage to 21.1 F in BACKLOG, NO NEW ISSUES: SQL Execution Mar 10, 2021
@asubiotto asubiotto mentioned this issue Mar 15, 2021
Merged
@asubiotto asubiotto moved this from Possible Starter Projects to 21.1 F in Cluster Observability Mar 15, 2021
@craig craig bot closed this as completed in 98ae002 Mar 16, 2021
Cluster Observability automation moved this from 21.1 F to Done Mar 16, 2021
@asubiotto asubiotto moved this from 21.1 F to 21.1 F Done in BACKLOG, NO NEW ISSUES: SQL Execution Mar 16, 2021
@asubiotto asubiotto mentioned this issue Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asubiotto asubiotto

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add execution stats to node_statement_statistics asubiotto/cockroach
1 participant
@asubiotto