Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colexec: clean up handling of abandoned components #61679

Open
yuzefovich opened this issue Mar 9, 2021 · 1 comment
Open

colexec: clean up handling of abandoned components #61679

yuzefovich opened this issue Mar 9, 2021 · 1 comment
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Mar 9, 2021

During the planning of vectorized flows, there are scenarios when certain operators are abandoned after they have been created (i.e. they become optimized out of the tree). Examples are columnarizers being removed from the flow (3c54450) or special queries like SELECT 1 FROM t HAVING true for which we plan fixedNumTuplesNoInputOp with no inputs. This works well for the main tree for the execution purposes, but it can break the assumptions of DrainMeta/Close method implementations that Init has been called.

In #61306 (comment) Alfonso suggested a nice idea to keep track of this state during the planning and disabling certain components when they are abandoned.

Jira issue: CRDB-2974

@yuzefovich yuzefovich added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Mar 9, 2021
@yuzefovich yuzefovich added this to Triage in BACKLOG, NO NEW ISSUES: SQL Execution via automation Mar 9, 2021
@asubiotto asubiotto moved this from Triage to [VECTORIZED BACKLOG] Enhancements/Features/Investigations in BACKLOG, NO NEW ISSUES: SQL Execution Mar 9, 2021
@jlinder jlinder added the T-sql-queries SQL Queries Team label Jun 16, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team
Projects
BACKLOG, NO NEW ISSUES: SQL Execution
[VECTORIZED BACKLOG] Enhancements/Fea...
Status: Cold Storage
Development

No branches or pull requests

2 participants