Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: give option to send notices immediately #67156

Open
otan opened this issue Jul 1, 2021 · 0 comments
Open

sql: give option to send notices immediately #67156

otan opened this issue Jul 1, 2021 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Sessions - Deprecated

Comments

@otan
Copy link
Contributor

otan commented Jul 1, 2021 •
edited by cockroach-jira-scripts

Currently we have BufferClientNotice, which only sends the notice over the pgconn if a command succeeds.

In reality, the PostgreSQL protocol allows errors to be sent at anytime:

A frontend must be prepared to accept ErrorResponse and NoticeResponse messages whenever it is expecting any other type of message. See also Section 46.2.6 concerning messages that the backend might generate due to outside events.

This has previously been tried in the past, we need it over the finish line.

Jira issue: CRDB-8399
@otan otan added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 1, 2021
@otan otan added this to Triage in SQL Sessions - Deprecated via automation Jul 1, 2021
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jul 1, 2021
@rafiss rafiss changed the title sql: give option to send hints immediately sql: give option to send notices immediately Aug 9, 2021
@rafiss rafiss moved this from Triage to Longer term backlog in SQL Sessions - Deprecated Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Sessions - Deprecated
Longer term backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otan