Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bazelisk should be go-get'ed to ./bin #69072

Open
dt opened this issue Aug 18, 2021 · 2 comments
Open

build: bazelisk should be go-get'ed to ./bin #69072

dt opened this issue Aug 18, 2021 · 2 comments
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@dt
Copy link
Member

dt commented Aug 18, 2021

Generally go getable tools required by make, like crlfmt or buf are automatically installed in ./bin which make adds to its PATH and most engineers probably add to their PATH as well. It seems like given that running bazel is required to prepare a green patch now (i.e. CI will fail if make bazel-generate was not run, which invokes bazel), we should treat it like other tools that make requires, and GOBIN=./bin go get github.com/bazelbuild/bazelisk it along with all the other build tools, and probably also then symlink bin/bazel to bin/bazelisk?

Epic CRDB-17171

@dt dt added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf labels Aug 18, 2021
@dt
Copy link
Member Author

dt commented Aug 18, 2021

cc @rickystewart

Copy link

github-actions bot commented May 1, 2024

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Development

No branches or pull requests

3 participants