Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: better eviction policy for sql stats in-memory store #69303

Closed
Tracked by #64743
Azhng opened this issue Aug 24, 2021 · 1 comment
Closed
Tracked by #64743

sql: better eviction policy for sql stats in-memory store #69303

Azhng opened this issue Aug 24, 2021 · 1 comment
Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@Azhng
Copy link
Contributor

Azhng commented Aug 24, 2021

Currently, when the in-memory sql stats store is full, it will attempt to flush the in-memory stats into the system table. During that time, all stats for new fingerprint IDs will be discarded.

If the system table is down (for various different reasons) for the flush, then we will not be able to record any new statistics since the sql stats flush will entering into crash loop. In this case, current sql stats behaviour means we will not able to record any new statistics with new fingerperintID.

We want a better eviction strategy to better handle the failure scenarios. A good starting point is the last paragraph in the future work section in the original RFC.

Jira issue: CRDB-9537

@Azhng Azhng added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-observability Related to observability of the SQL layer T-sql-observability labels Aug 24, 2021
@Azhng Azhng added this to Triage in Cluster Observability via automation Aug 24, 2021
@maryliag maryliag moved this from Triage to Backlog in Cluster Observability Aug 30, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Cluster Observability automation moved this from Backlog to Done Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
No open projects
Development

No branches or pull requests

1 participant