Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: create changefeed from previous changefeed #69348

Open
shermanCRL opened this issue Aug 25, 2021 · 4 comments
Open

cdc: create changefeed from previous changefeed #69348

shermanCRL opened this issue Aug 25, 2021 · 4 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@shermanCRL
Copy link
Contributor

shermanCRL commented Aug 25, 2021

Is your feature request related to a problem? Please describe.

If a changefeed has failed, and an operator wishes to create a new identically-configured changefeed, it is tedious to retrieve the previous changefeed CREATE command. (Selecting against SHOW JOBS, then selecting the command, etc).

Describe the solution you'd like

Syntax to allow creating a new changefeed, given a job id(s) for the failed changefeed.

Maybe CREATE CHANGEFEED FROM JOB 123456, but I don’t have strong opinions on the syntax particulars.

Jira issue: CRDB-9553

@shermanCRL shermanCRL added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 25, 2021
@shermanCRL shermanCRL added this to Triage in [DEPRECATED] CDC via automation Aug 25, 2021
@blathers-crl blathers-crl bot added the T-cdc label Aug 25, 2021
@shermanCRL
Copy link
Contributor Author

Need to think about security concerns here. Would copying a job provide a path to see credentials created by someone else?

@shermanCRL
Copy link
Contributor Author

Possible this is better addressed via CREATE CHANGEFEED FROM TEMPLATE?

Syntax idea from @HonoreDB : CREATE CHANGEFEED LIKE, similar to CREATE TABLE LIKE.

@amruss amruss moved this from Triage to UX improvements in [DEPRECATED] CDC Aug 30, 2021
@miretskiy
Copy link
Contributor

I'm inclined to close this issue; Ideally, changefeeds should not fail -- and there has
been a lot of progress in that space. So, such a feature would have very limited
use case in my opinion.

@shermanCRL -- please close this issue, or keep it open if you disagree.

@shermanCRL
Copy link
Contributor Author

shermanCRL commented Jan 9, 2023

We can probably keep this idea in the backlog -- I think it makes sense from a “fleet management” perspective, i.e. “I need to create a bunch of changefeeds and can you save me some tedium”. But it’s sugar, like copy-paste, and may not have an actual customer advocates, I will ask around.

Agree that it’s become less relevant as a way of recovering from failures, which was an initial motivation.

Actually, maybe SHOW CREATE CHANGEFEED <jobid> is a better answer.

@shermanCRL shermanCRL changed the title cdc: create changefeed from failed changefeed (job) cdc: create changefeed from previous changefeed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
[DEPRECATED] CDC
  
UX improvements
Development

No branches or pull requests

2 participants