Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiregionccl: add mutations to TestMultiRegionDataDriven #73971

Open
Tracked by #77439
rytaft opened this issue Dec 17, 2021 · 0 comments
Open
Tracked by #77439

multiregionccl: add mutations to TestMultiRegionDataDriven #73971

rytaft opened this issue Dec 17, 2021 · 0 comments
Labels
A-multiregion Related to multi-region A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team
Projects
SQL Queries

Comments

@rytaft
Copy link
Collaborator

rytaft commented Dec 17, 2021 •
edited by cockroach-jira-scripts

The tests in TestMultiRegionDataDriven test that certain queries are served locally or remotely, as expected. We should add tests that mutations are either local or remote. For example, INSERTs into REGIONAL BY ROW tables should always touch all regions (and therefore cannot be served locally) if they need to check the validity of UNIQUE constraints. This type of testing may have been able to catch #73024, and will hopefully avoid future similar bugs.

Jira issue: CRDB-11833
@rytaft rytaft added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure O-postmortem Originated from a Postmortem action item. labels Dec 17, 2021
@rytaft rytaft added this to Triage in SQL Queries via automation Dec 17, 2021
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Dec 17, 2021
@rytaft rytaft added the A-multiregion Related to multi-region label Dec 17, 2021
@mgartner mgartner added the E-quick-win Likely to be a quick win for someone experienced. label Jan 4, 2022
@mgartner mgartner moved this from Triage to 22.1 High Likelihood (90%) in SQL Queries Jan 4, 2022
@rytaft rytaft mentioned this issue Mar 7, 2022
Open
20 tasks
@rytaft rytaft moved this from 22.1 High Likelihood (90%) to 22.2 High Likelihood (90%) in SQL Queries May 13, 2022
@mgartner mgartner moved this from Up Next to 22.2 Release in SQL Queries May 31, 2022
@rytaft rytaft moved this from 22.2 Release to 23.1 Release in SQL Queries Oct 27, 2022
@mgartner mgartner moved this from 23.1 Release to Backlog in SQL Queries Jan 5, 2023
@mgartner mgartner removed the O-postmortem Originated from a Postmortem action item. label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-multiregion Related to multi-region A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Backlog
SQL Queries
Backlog (DO NOT ADD NEW ISSUES)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgartner @rytaft