Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextutil: RunWithTimeout error message is misleading #79424

Closed
erikgrinaker opened this issue Apr 5, 2022 · 0 comments · Fixed by #79767
Closed

contextutil: RunWithTimeout error message is misleading #79424

erikgrinaker opened this issue Apr 5, 2022 · 0 comments · Fixed by #79767
Assignees
@erikgrinaker
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv-replication KV Replication Team

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Apr 5, 2022 •
edited by cockroach-jira-scripts

contextutil.RunWithTimeout gives error messages like:

operation "send-snapshot" timed out after 1h0m0s (took 10s): ‹rpc error: code = DeadlineExceeded desc = context deadline exceeded›

Where 1h0m0s is the timeout passed to RunWithTimeout(). However, this is misleading, because either the caller or callee can have set their own context timeout that is smaller than the timeout given to RunWithTimeout.

This is even worse in older releases, where the "(took 10s)" part is not present, leading readers to believe the operation actually took 1 hour.

Jira issue: CRDB-14833
@erikgrinaker erikgrinaker added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Apr 5, 2022
@erikgrinaker erikgrinaker self-assigned this Apr 5, 2022
@erikgrinaker erikgrinaker added this to Incoming in Replication via automation Apr 5, 2022
@erikgrinaker erikgrinaker added the T-kv-replication KV Replication Team label Apr 5, 2022
@erikgrinaker erikgrinaker mentioned this issue Apr 5, 2022
Open
@erikgrinaker erikgrinaker moved this from Incoming to Quick Wins in Replication Apr 6, 2022
@erikgrinaker erikgrinaker mentioned this issue Apr 11, 2022
Merged
@craig craig bot closed this as completed in 6de7a18 Apr 11, 2022
Replication automation moved this from Quick Wins to Done Apr 11, 2022
@blathers-crl blathers-crl bot mentioned this issue Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv-replication KV Replication Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util/contextutil: clarify RunWithTimeout error message erikgrinaker/cockroach
2 participants
@jlinder @erikgrinaker