Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: Improve avro coverage in unit tests. #80285

Open
HonoreDB opened this issue Apr 20, 2022 · 2 comments
Open

cdc: Improve avro coverage in unit tests. #80285

HonoreDB opened this issue Apr 20, 2022 · 2 comments
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. T-cdc
Projects
[DEPRECATED] CDC

Comments

@HonoreDB
Copy link
Contributor

HonoreDB commented Apr 20, 2022 •
edited by exalate-issue-sync bot

Our unit test suite doesn't have as good coverage for avro as for json (e.g. no tests with WITH format=avro, updated). This is because it's annoying to write assertPayloads for avro. As we start adding more formats, it's going to be useful to have the ability to write tests that document behavior shared among multiple encoders in a format-agnostic way, say by converting the output to json or a struct before asserting things about it.

Jira issue: CRDB-15785

Epic CRDB-9179
@HonoreDB HonoreDB added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Apr 20, 2022
@blathers-crl
Copy link

blathers-crl bot commented Apr 20, 2022

cc @cockroachdb/cdc

@blathers-crl blathers-crl bot added this to Triage in [DEPRECATED] CDC Apr 20, 2022
@amruss amruss moved this from Triage to Testing in [DEPRECATED] CDC Apr 27, 2022
@amruss
Copy link
Contributor

amruss commented Apr 27, 2022

w/ registry we're assuming avro, w/o registry we're assuming json

@amruss amruss added the E-quick-win Likely to be a quick win for someone experienced. label Apr 27, 2022
@jlinder jlinder added sync-me and removed sync-me labels May 20, 2022
@HonoreDB HonoreDB added the stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. label Apr 6, 2023
@HonoreDB HonoreDB self-assigned this Apr 19, 2023
@miretskiy miretskiy changed the title cdc: format-agnostic unit tests cdc: Improve avro coverage in unit tests. Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. T-cdc
Projects
[DEPRECATED] CDC
  
Testing
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlinder @HonoreDB @amruss