Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptance: acceptance tests should download prebuilt Docker images, not build them at test time #81405

Open
rickystewart opened this issue May 17, 2022 · 1 comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented May 17, 2022

Last week the acceptance test TestComposeGSSPython started failing with the following error:

        python_1     | psql: error: private key file "/certs/client.root.key" must be owned by the current user or root

This is because the postgresql-client apt package was updated to pull in a new version of postgres, including this change. With #81313 I worked around this by manually pulling in an older version of postgresql-client (postgresql-client-11) that does not have this behavior. This is a temporary workaround that doesn't actually address the root cause of the issue, which is that building docker images at test time may result in a test environment that we have never tested before and which is not guaranteed to actually work.

Instead we should build these docker images once and reference them via tag, as is typically done with docker. This will ensure that our test environments don't suddenly change under us.

Jira issue: CRDB-15204

@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-testeng TestEng Team labels May 17, 2022
@jlinder jlinder added sync-me and removed sync-me labels May 20, 2022
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
None yet
Development

No branches or pull requests

2 participants