Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: point roachtest default binary path to bazel binary path #86602

Open
msbutler opened this issue Aug 22, 2022 · 0 comments
Open

bazel: point roachtest default binary path to bazel binary path #86602

msbutler opened this issue Aug 22, 2022 · 0 comments
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@msbutler
Copy link
Collaborator

msbutler commented Aug 22, 2022 •
edited by exalate-issue-sync bot

Currently, roachtest run by default looks for binaries where make would normally generate them, but not bazel. This means the user has to explicitly pass the path to the bazel built binaries, via

roachtest run backupTPCC --cockroach 'artifacts/cockroach'

Since we're sunsetting make, roachtest should by default look for the bazel binaries.

Jira issue: CRDB-18835
Epic CRDB-17171
@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf labels Aug 22, 2022
@msbutler msbutler mentioned this issue Aug 22, 2022
Merged
@rickystewart rickystewart added A-build-system A-testing Testing tools and infrastructure and removed A-build-system labels Aug 22, 2022
@irfansharif irfansharif self-assigned this Sep 19, 2022
@irfansharif irfansharif removed their assignment Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rickystewart @irfansharif @msbutler