Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: add cancellation checks to expensive exploration rules #87585

Open
5 tasks
DrewKimball opened this issue Sep 8, 2022 · 0 comments
Open
5 tasks

opt: add cancellation checks to expensive exploration rules #87585

DrewKimball opened this issue Sep 8, 2022 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. O-qa T-sql-queries SQL Queries Team
Projects

Comments

@DrewKimball
Copy link
Collaborator

DrewKimball commented Sep 8, 2022

#85041 added some cancellation checks to the optimizer. However, there are a few exploration rules that can take significant time to complete for complex queries - for example, ReorderJoins can take a long time when the join limit is increased and/or join properties are expensive to calculate, and GenerateLookupJoins is expensive when there are many candidate indexes. We should consider adding cancellation checks to the following rules, as well as their variants (if any):

  • ReorderJoins
  • GenerateMergeJoins
  • GenerateLookupJoins
  • GenerateConstrained/Limited/IndexScans
  • GenerateZigzagJoins

Jira issue: CRDB-19428

@DrewKimball DrewKimball added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-qa labels Sep 8, 2022
@DrewKimball DrewKimball added this to Triage in SQL Queries via automation Sep 8, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Sep 8, 2022
@yuzefovich yuzefovich moved this from Triage to 23.1 Release in SQL Queries Sep 27, 2022
@mgartner mgartner moved this from 23.1 Release to Backlog in SQL Queries Jan 5, 2023
@mgartner mgartner added the E-quick-win Likely to be a quick win for someone experienced. label Jan 5, 2023
@DrewKimball DrewKimball removed their assignment Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. O-qa T-sql-queries SQL Queries Team
Projects
Status: Backlog
SQL Queries
Backlog (DO NOT ADD NEW ISSUES)
Development

No branches or pull requests

2 participants