Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: redact errors output during explain analyze (redact) #99136

Open
rharding6373 opened this issue Mar 21, 2023 · 0 comments
Open

QA: redact errors output during explain analyze (redact) #99136

rharding6373 opened this issue Mar 21, 2023 · 0 comments
Labels
A-sql-debug-bundle Issues related to statement bundle improvements A-sql-explain Issues related to EXPLAIN and EXPLAIN ANALYZE improvements C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-qa S-2 Medium-high impact: many users impacted, risks of availability and difficult-to-fix data errors T-sql-queries SQL Queries Team
Projects

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented Mar 21, 2023

When a query fails during an explain analyze ... redact, we currently may include constants we would expect to be redacted in the error output.

In the following query and output using MOVR on cockroach demo:

EXPLAIN ANALYZE (PLAN, REDACT) INSERT INTO vehicle_location_histories (city, ride_id, timestamp, lat, long) VALUES ('amsterdam', 'cd032f56-cf1a-4800-8000-00000000066f', current_timestamp(), -101, 60)
 ERROR: insert on table "vehicle_location_histories" violates foreign key constraint "vehicle_location_histories_city_ride_id_fkey"
 SQLSTATE: 23503    
 DETAIL: Key (city, ride_id)=('amsterdam', 'cd032f56-cf1a-4800-8000-00000000066f') is not present in table "rides".
 CONSTRAINT: vehicle_location_histories_city_ride_id_fkey

We would expect constants like 'amsterdam', 'cd032f56-cf1a-4800-8000-00000000066f' to be redacted from the explain output, so should we expect them to be redacted from the error output as well?

Jira issue: CRDB-25719

@rharding6373 rharding6373 added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Mar 21, 2023
@rharding6373 rharding6373 added this to Triage in SQL Queries via automation Mar 21, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Mar 21, 2023
@michae2 michae2 added the O-qa label Mar 22, 2023
@rharding6373 rharding6373 moved this from Triage to New Backlog in SQL Queries Mar 28, 2023
@rharding6373 rharding6373 moved this from New Backlog to Bugs to Fix in SQL Queries Mar 28, 2023
@mgartner mgartner added the S-2 Medium-high impact: many users impacted, risks of availability and difficult-to-fix data errors label Jun 8, 2023
@michae2 michae2 added A-sql-debug-bundle Issues related to statement bundle improvements A-sql-explain Issues related to EXPLAIN and EXPLAIN ANALYZE improvements labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-debug-bundle Issues related to statement bundle improvements A-sql-explain Issues related to EXPLAIN and EXPLAIN ANALYZE improvements C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-qa S-2 Medium-high impact: many users impacted, risks of availability and difficult-to-fix data errors T-sql-queries SQL Queries Team
Projects
Status: Bugs to Fix
SQL Queries
Bugs to Fix
Development

No branches or pull requests

3 participants