Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: Introduce RunBefore and RunAfter #99951

Open
smg260 opened this issue Mar 29, 2023 · 1 comment
Open

roachtest: Introduce RunBefore and RunAfter #99951

smg260 opened this issue Mar 29, 2023 · 1 comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
Test Engineering

Comments

@smg260
Copy link
Contributor

smg260 commented Mar 29, 2023 •
edited by cockroach-jira-scripts

Today the test spec allows a writer to provide a single Run function, which ends up incorporating all the test setup and teardown activity.

This is a proposal to add optional RunBefore and RunAfter functions which would be invoked by the harness. It would allow for cleaner separation of setup and actual test code, allow us to further categorise errors by phase, and more accurately get a sense of how long a test actually takes.

Jira issue: CRDB-26153
@smg260 smg260 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Mar 29, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 29, 2023

cc @cockroachdb/test-eng

@blathers-crl blathers-crl bot added this to Triage in Test Engineering Mar 29, 2023
@smg260 smg260 added the A-testing Testing tools and infrastructure label Mar 29, 2023
This was referenced May 29, 2023
Draft
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
Test Engineering
Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smg260