go.mod: update grpc-gateway to v2 #9
Draft
+54
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffSwenson
force-pushed
the
jeffswenson-update-grpc-gateway
branch
3 times, most recently
from
0727715
to
bd1986b
Compare
Attempting to build grpc-gateway v1 using the latest version of io_bazel_go_rules fails due to a breaking change in how io_bazel_go_rules resolves googleapi protobufs (https://github.com/bazelbuild/rules_go/releases/tag/v0.41.0). Version v2.15.2 was chosen because it is a relatively recent version that occurs before the breaking change was fixed in grpc-gateway. This allows cockroachdb to import the change without bumping the io_bazel_rules_go version. Other repositories that want to bump their io_bazel_rules_go can explicitly depend on a version of grpc-gatewy that includes the bazel fix.
JeffSwenson
force-pushed
the
jeffswenson-update-grpc-gateway
branch
from
bd1986b
to
04c2181
Compare
JeffSwenson
changed the title
Jeremyyang920
added a commit
that referenced
this pull request
Feb 13, 2024
This commit takes the changes from #9 and applies them as a patch on top of new snapshots until we resolve the dependency issues.
Jeremyyang920
added a commit
that referenced
this pull request
Feb 13, 2024
This commit takes the changes from #9 and applies them as a patch on top of new snapshots until we resolve the dependency issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to build grpc-gateway v1 using the latest version of io_bazel_go_rules
fails due to a breaking change in how io_bazel_go_rules resolves googleapi
protobufs (https://github.com/bazelbuild/rules_go/releases/tag/v0.41.0).
Version v2.15.2 was chosen because it is a relatively recent version
that occurs before the breaking change was fixed in grpc-gateway. This
allows cockroachdb to import the change without bumping the io_bazel_rules_go
version. Other repositories that want to bump their io_bazel_rules_go can
explicitly depend on a version of grpc-gatewy that includes the bazel fix.