Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for psycopg3 #256

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Conversation

timgraham
Copy link
Collaborator

@timgraham timgraham commented May 21, 2022

Support is forthcoming in Django 4.2 (django/django#15687).

@rafiss
Copy link
Contributor

rafiss commented May 22, 2022

Nice! As a heads up, we currently have a project underway to reach official support with psycopg3. You can see some of the issues here: https://github.com/cockroachdb/cockroach/issues?q=is%3Aissue+author%3Advarrazzo

@kernfeld-cockroach
Copy link

The psycopg3 work to add support for CockroachDB is now merged.

@timgraham timgraham force-pushed the psycopg3 branch 2 times, most recently from a60dba6 to fa65cda Compare August 8, 2022 20:18
@timgraham timgraham force-pushed the psycopg3 branch 2 times, most recently from 43c7abd to bf39d5a Compare October 24, 2022 22:12
@timgraham timgraham force-pushed the psycopg3 branch 2 times, most recently from 0a23442 to c847ee0 Compare December 6, 2022 22:28
@timgraham timgraham force-pushed the psycopg3 branch 3 times, most recently from 8642d9b to 34fd4c0 Compare December 14, 2022 23:16
@timgraham timgraham force-pushed the psycopg3 branch 3 times, most recently from f8e31a1 to a7e4345 Compare January 28, 2023 01:36
@timgraham timgraham force-pushed the psycopg3 branch 3 times, most recently from a3a62a9 to 6b2df0a Compare March 30, 2023 15:20
@timgraham timgraham changed the title [wip] add support for psycopg3 add support for psycopg3 Mar 30, 2023
@timgraham timgraham marked this pull request as ready for review March 30, 2023 17:38
@timgraham timgraham requested a review from rafiss March 30, 2023 17:40
@timgraham timgraham force-pushed the psycopg3 branch 2 times, most recently from 7cf38b0 to 6173830 Compare April 3, 2023 13:09
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

…sql_flush()

I removed this with CockroachDB 21.2.x support as I couldn't reproduce
failures with CockroachDB 22.1.x and later, but I've now seen the failure
with CockroachDB 23.1.x alpha 8. The code is now psycopg3 compatible.
@timgraham timgraham merged commit 525391a into cockroachdb:master Apr 6, 2023
@timgraham timgraham deleted the psycopg3 branch April 6, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants