Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
taroface committed Mar 29, 2024
1 parent c4ec112 commit b4eaf59
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/current/_includes/v23.2/misc/force-index-selection.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,5 +138,5 @@ Time: 1ms total (execution 1ms / network 0ms)
{% include {{ page.version.version }}/sql/no-full-scan.md %}

{{site.data.alerts.callout_success}}
For other methods of preventing full scans, see [Prevent the optimizer from planning full scans]({% link {{ page.version.version }}/performance-best-practices-overview.md %}#prevent-the-optimizer-from-planning-full-scans).
For other ways to prevent full table scans, refer to [Prevent the optimizer from planning full scans]({% link {{ page.version.version }}/performance-best-practices-overview.md %}#prevent-the-optimizer-from-planning-full-scans).
{{site.data.alerts.end}}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- At the cluster level, set `disallow_full_table_scans` for some or all users/roles. For example:
- At the cluster level, set `disallow_full_table_scans` for some or all users and roles. For example:

{% include_cached copy-clipboard.html %}
~~~ sql
Expand Down
2 changes: 1 addition & 1 deletion src/current/_includes/v23.2/sql/no-full-scan.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
SELECT * FROM table_name@{FORCE_INDEX=index_name,NO_FULL_SCAN} WHERE b > 0;
~~~

This will force a constrained scan of the partial index. If a constrained scan of the partial index is not possible, an error will be returned.
This forces a constrained scan of the partial index. If a constrained scan of the partial index is not possible, an error is returned.
2 changes: 1 addition & 1 deletion src/current/_includes/v23.2/sql/transactions-limit-rows.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
ALTER ROLE ALL SET transaction_rows_written_err = 1000;
~~~

To assess the impact of enabling these settings, use the corresponding session settings [`transaction_rows_read_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-read-log) and [`transaction_rows_written_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-written-log) to log transactions that read or write the specified number of rows. Transactions are logged to the [`SQL_PERF`]({% link {{ page.version.version }}/logging.md %}#sql_perf) channel.
To assess the impact of configuring these session settings, use the corresponding session settings [`transaction_rows_read_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-read-log) and [`transaction_rows_written_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-written-log) to log transactions that read or write the specified number of rows. Transactions are logged to the [`SQL_PERF`]({% link {{ page.version.version }}/logging.md %}#sql_perf) channel.
2 changes: 1 addition & 1 deletion src/current/_includes/v24.1/misc/force-index-selection.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,5 +138,5 @@ Time: 1ms total (execution 1ms / network 0ms)
{% include {{ page.version.version }}/sql/no-full-scan.md %}

{{site.data.alerts.callout_success}}
For other methods of preventing full scans, see [Prevent the optimizer from planning full scans]({% link {{ page.version.version }}/performance-best-practices-overview.md %}#prevent-the-optimizer-from-planning-full-scans).
For other ways to prevent full scans, refer to [Prevent the optimizer from planning full scans]({% link {{ page.version.version }}/performance-best-practices-overview.md %}#prevent-the-optimizer-from-planning-full-scans).
{{site.data.alerts.end}}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- At the cluster level, set `disallow_full_table_scans` for some or all users/roles. For example:
- At the cluster level, set `disallow_full_table_scans` for some or all users and roles. For example:

{% include_cached copy-clipboard.html %}
~~~ sql
Expand Down
2 changes: 1 addition & 1 deletion src/current/_includes/v24.1/sql/no-full-scan.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
SELECT * FROM table_name@{FORCE_INDEX=index_name,NO_FULL_SCAN} WHERE b > 0;
~~~

This will force a constrained scan of the partial index. If a constrained scan of the partial index is not possible, an error will be returned.
This forces a constrained scan of the partial index. If a constrained scan of the partial index is not possible, an error is returned.
2 changes: 1 addition & 1 deletion src/current/_includes/v24.1/sql/transactions-limit-rows.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
ALTER ROLE ALL SET transaction_rows_written_err = 1000;
~~~

To assess the impact of enabling these settings, use the corresponding session settings [`transaction_rows_read_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-read-log) and [`transaction_rows_written_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-written-log) to log transactions that read or write the specified number of rows. Transactions are logged to the [`SQL_PERF`]({% link {{ page.version.version }}/logging.md %}#sql_perf) channel.
To assess the impact of configuring these session settings, use the corresponding session settings [`transaction_rows_read_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-read-log) and [`transaction_rows_written_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-written-log) to log transactions that read or write the specified number of rows. Transactions are logged to the [`SQL_PERF`]({% link {{ page.version.version }}/logging.md %}#sql_perf) channel.

0 comments on commit b4eaf59

Please sign in to comment.