Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timetz datatype #2982

Closed
jseldess opened this issue Apr 20, 2018 · 6 comments
Closed

Support timetz datatype #2982

jseldess opened this issue Apr 20, 2018 · 6 comments
Assignees
@Amruta-Ranade
Projects
v2.1.0-alpha.20180604
Milestone
2.1

Comments

@jseldess
Copy link
Contributor

Background: https://airtable.com/tblD3oZPLJgGhCmch/viw8IfZMg9Up8SP33/recgAULbWY1898miw
PM: @awoods187
Eng Partner:
@jseldess jseldess added this to the 2.1 milestone Apr 20, 2018
@jseldess
Copy link
Contributor Author

jseldess commented May 1, 2018

This feature is available in the v2.1.0-alpha.20170507 release. @rmloveland, I might try to get it documented in time.

@jseldess jseldess added the ready label May 1, 2018
jseldess added a commit that referenced this issue May 4, 2018
@jseldess
Document the TIMETZ type
7ed9861 
Also minor tweaks to the TIMEZONE type docs.

Fixes #2982
@jseldess jseldess mentioned this issue May 4, 2018
Merged
@jseldess jseldess self-assigned this May 4, 2018
@jseldess jseldess added in progress and removed ready labels May 4, 2018
@rmloveland
Copy link
Contributor

Cockroach PR that introduced (for reference):

rmloveland pushed a commit that referenced this issue May 9, 2018
@jseldess @rmloveland
Document the TIMETZ type
c69ba36 
Fixes #2982

Summary of changes:

- Make clear that TIMETZ is not really recommended, just there for SQL
  standard and ORM support (2.1)

- Give examples of wonkiness: comparisons and ordering (2.1)

- Update SQL Feature page with TIME data type (2.0 and 2.1)

- Update example to use TIME, not TIMETZ

- Add links to other related docs as appropriate: Postgres time stuff
  and wire protocol, Cockroach SQL feature page and functions/operators

- Fixed a few small typos/copy-edits

- Also minor tweaks to the TIMEZONE type docs
@rmloveland rmloveland added this to In review in v2.1.0-alpha.20180604 May 14, 2018
rmloveland pushed a commit that referenced this issue May 16, 2018
@jseldess @rmloveland
Document the TIMETZ type
c172539 
Fixes #2982

Summary of changes:

- Make clear that TIMETZ is not really recommended, just there for SQL
  standard and ORM support (2.1)

- Give examples of wonkiness: comparisons and ordering (2.1)

- Update SQL Feature page with TIME data type (2.0 and 2.1)

- Update example to use TIME, not TIMETZ

- Add links to other related docs as appropriate: Postgres time stuff
  and wire protocol, Cockroach SQL feature page and functions/operators

- Fixed a few small typos/copy-edits

- Also minor tweaks to the TIMEZONE type docs
v2.1.0-alpha.20180604 automation moved this from In review to Done May 16, 2018
@jseldess
Copy link
Contributor Author

jseldess commented Jun 5, 2018

Based on #3254, TIMETZ docs strongly warn users against using this feature.

It's unclear what will happen with this type (cockroachdb/cockroach#25224), so reopening this issue for now.

@jseldess jseldess reopened this Jun 5, 2018
@jseldess jseldess added ready and removed in progress labels Jun 5, 2018
@jseldess jseldess removed their assignment Jul 3, 2018
@jseldess
Copy link
Contributor Author

@rmloveland, based on the updated roadmap, we're going to hide this feature in 2.1. The remaining docs work, therefore, is just to remove mention of timetz from the docs.

@jseldess
Copy link
Contributor Author

From first 2.1 beta:

Support for PostgreSQL's TIMETZ data type has been removed due to incomplete/incorrect implementation. This feature was available only in previous 2.1 alpha releases. Before upgrading to this release, tables with the TIMETZ type must be dropped entirely; it is not possible to convert the data or drop a single TIMETZ column. #28095

@jseldess jseldess assigned Amruta-Ranade and unassigned rmloveland Aug 28, 2018
@Amruta-Ranade
Copy link
Contributor

Doc impact:

  • TIME page
  • Data types page

@Amruta-Ranade Amruta-Ranade mentioned this issue Aug 30, 2018
Merged
jseldess added a commit that referenced this issue Aug 30, 2018
@jseldess
Update v2.1 functions and operators
0bcbca9 
Fixes #3627.
Fixes #3626.
Partially addresses #2982.
@jseldess jseldess mentioned this issue Aug 30, 2018
Merged
@jseldess jseldess mentioned this issue Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amruta-Ranade Amruta-Ranade

Labels
None yet
Projects
No open projects
v2.1.0-alpha.20180604
  
Done
Milestone
2.1
Development

No branches or pull requests
3 participants
@rmloveland @Amruta-Ranade @jseldess