Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: Prune Delete operator input columns #4378

Closed
jseldess opened this issue Feb 12, 2019 · 0 comments · Fixed by #4581
Closed

opt: Prune Delete operator input columns #4378

jseldess opened this issue Feb 12, 2019 · 0 comments · Fixed by #4581
Assignees
@rmloveland
Labels
C-product-change P-1 High priority; must be done this release
Milestone
19.1

Comments

@jseldess
Copy link
Contributor

PR: cockroachdb/cockroach#34303

From release notes:

The ORDER BY clause can no longer be used with a DELETE statement when there is no LIMIT clause present. Sorting the output should instead be done using SELECT ... FROM [DELETE ...] ORDER BY .... [#34303][#34303] {% comment %}doc{% endcomment %}
@jseldess jseldess added this to the 2.2 milestone Feb 12, 2019
@jseldess jseldess added A-sql P-1 High priority; must be done this release labels Feb 13, 2019
@jseldess jseldess modified the milestones: 2.2, 19.1 Feb 25, 2019
rmloveland added a commit that referenced this issue Mar 27, 2019
@rmloveland
LIMIT is required on a DELETE ... ORDER BY
41686a0 
Fixes #4378.

Summary of changes:

- Add new section 'Sorting the output of deletes' to both the `DELETE`
  and 'Ordering Query Results' pages.

- Add example section 'Sort an return deleted rows' to the `DELETE` page

- Update all examples on `DELETE` page to use new SQL CLI output table
  formatting

- Add SQL code needed for `DELETE` examples in a comment at the bottom
  of the page
@rmloveland rmloveland mentioned this issue Mar 27, 2019
Merged
rmloveland added a commit that referenced this issue Apr 8, 2019
@rmloveland
LIMIT is required on a DELETE ... ORDER BY
61e680f 
Fixes #4378.

Summary of changes:

- Update `DELETE`'s `sort_clause` parameter to note that as of 19.1, a
  `LIMIT` is required on a `DELETE ... ORDER BY`

- Add new section 'Sorting the output of deletes' to both the `DELETE`
  and 'Ordering Query Results' pages.

- Add example section 'Sort an return deleted rows' to the `DELETE` page

- Update all examples on `DELETE` page to use new SQL CLI output table
  formatting

- Add SQL code needed for `DELETE` examples in a comment at the bottom
  of the page
@rmloveland rmloveland mentioned this issue Apr 11, 2019
Merged
rmloveland added a commit that referenced this issue Apr 15, 2019
@rmloveland
LIMIT is required on a DELETE ... ORDER BY
a5232d3 
Fixes #4378.

Summary of changes:

- Update `DELETE`'s `sort_clause` parameter to note that as of 19.1, a
  `LIMIT` is required on a `DELETE ... ORDER BY`

- Add new section 'Sorting the output of deletes' to both the `DELETE`
  and 'Ordering Query Results' pages.

- Add example section 'Sort an return deleted rows' to the `DELETE` page

- Update all examples on `DELETE` page to use new SQL CLI output table
  formatting

- Add SQL code needed for `DELETE` examples in a comment at the bottom
  of the page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
C-product-change P-1 High priority; must be done this release
Projects
None yet
Milestone
19.1
Development

Successfully merging a pull request may close this issue.

LIMIT is required on a DELETE ... ORDER BY cockroachdb/docs
2 participants
@rmloveland @jseldess