Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSR approval missing from Kubernetes training #4803

Closed
jseldess opened this issue May 14, 2019 · 2 comments · Fixed by #4812
Closed

CSR approval missing from Kubernetes training #4803

jseldess opened this issue May 14, 2019 · 2 comments · Fixed by #4812
Assignees
@jseldess
Labels
C-doc-improvement T-something-broken
Milestone
19.2

Comments

@jseldess
Copy link
Contributor

From a user:

In the kubernetes scaling section, the approval of the csr request is missing.
https://www.cockroachlabs.com/docs/v19.1/training/orchestration-with-kubernetes.html
The rest is working very well.
@jseldess jseldess added this to the 19.2 milestone May 14, 2019
@ikzelf
Copy link

ikzelf commented May 14, 2019

also in removing nodes: suddenly there is --insecure.
Should have been
kubectl exec -it cockroachdb-client-secure -- ./cockroach node decommission --certs-dir=/cockroach-certs --host=cockroachdb-public

jseldess added a commit that referenced this issue May 15, 2019
@jseldess
Fix k8s training module
a03f704 
- Add step for approving CSR for added node
- Change decommission command to use secure flag

Fixes #4803.
@jseldess jseldess self-assigned this May 15, 2019
@jseldess jseldess mentioned this issue May 15, 2019
Merged
@jseldess
Copy link
Contributor Author

Thanks for catching this errors, @ikzelf. Just opened a PR with fixes: #4812

@jseldess jseldess added A-ops and removed A-channel labels Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jseldess jseldess

Labels
C-doc-improvement T-something-broken
Projects
None yet
Milestone
19.2
Development

Successfully merging a pull request may close this issue.

Kubernetes training updates cockroachdb/docs
2 participants
@ikzelf @jseldess