preserve dots when copying to clipboard #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the copy-to-clipboard sanitizing regex was sourced from a StackOverflow question titled "Regex for removing leading and trailing carriage returns and line feeds from a sentence" (https://stackoverflow.com/a/2550845/1122351), but the question text sneakily also asked to combine this with "removing periods from within the string." We want to keep these dots when copying to the clipboard, so remove the part of the regex that strips these dots.
|
This change is |
|
(@jseldess: heads up, I haven't tested this yet.) |
Merged
|
Thanks, @benesch. Will test in the morning. @deronjohnson, heads up that @benesch may have resolved this already. |
knz
approved these changes
Jun 27, 2017
|
Just tested. Works like a charm. Thanks again, @benesch! |
jseldess
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the copy-to-clipboard sanitizing regex was sourced from a StackOverflow question titled "Regex for removing leading and trailing carriage returns and line feeds from a sentence" (https://stackoverflow.com/a/2550845/1122351), but the question text sneakily also asked for the solution to combine this with "removing periods from within the string."
We want to keep these dots when copying to the clipboard, so remove the part of the regex that strips these dots.