Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-8579 DOC-8580 Docs for Datadog and Cloudwatch metrics integration for Standard clusters #18241

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Jan 24, 2024

Fixes DOC-8579 DOC-8580

Created Export Metrics Standard page by copying Export Metrics Dedicated page and modifying as follows: (1) replaced site.data.products.dedicated with site.data.products.standard. (2) replaced instances of nodes with regions. (3) removed repetition in intro sentence for Datadog. (4) modified 2 steps for enabling AWS Cloudwatch.

In sidebar, added link to Export Metrics Standard page.

Copy link

github-actions bot commented Jan 24, 2024

Files changed:

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit faf82e9
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/65d8e62271986e0008912d82

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit faf82e9
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/65d8e622608e57000901ccd6

Copy link

netlify bot commented Jan 24, 2024

Netlify Preview

Name Link
🔨 Latest commit 887d9b7
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/65d911549a943f0008165bb3
😎 Deploy Preview https://deploy-preview-18241--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@jaylim-crl jaylim-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/current/cockroachcloud/export-metrics-standard.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-standard.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-standard.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-standard.md Outdated Show resolved Hide resolved
@florence-crl florence-crl removed the request for review from alyshanjahani-crl January 25, 2024 14:29
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

src/current/cockroachcloud/export-metrics-standard.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-standard.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-standard.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-standard.md Outdated Show resolved Hide resolved
….dedicated with hardcoded Standard. (2) replaced instances of nodes with regions. (3) removed repetition in intro sentence for Datadog. (4) modified 2 steps for enabling AWS Cloudwatch.
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Too bad there's a lot of duplication here but over time maybe we can do this with conditional logic once the whole Standard etc. situation shakes out more fully

@florence-crl florence-crl changed the base branch from main to cloud-2.0 February 23, 2024 18:38
@florence-crl florence-crl merged commit aa6b202 into cloud-2.0 Feb 23, 2024
4 checks passed
@florence-crl florence-crl deleted the DOC-8579 branch February 23, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants