Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes docs to reflect that pods aren't "Ready" before init #3291

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

a-robinson
Copy link
Contributor

This is true as of the updates that we made to the Kubernetes config for
v2.0.

@a-robinson a-robinson requested a review from jseldess June 21, 2018 16:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @a-robinson!

This is true as of the updates that we made to the Kubernetes config for
v2.0.
@a-robinson
Copy link
Contributor Author

I've gone and added a note to the initialization step that the pods should now be ready. Still look ok?

@jseldess
Copy link
Contributor

Still LGTM. Thanks, @a-robinson!

@a-robinson a-robinson merged commit 5262023 into cockroachdb:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants