Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all SHOW statements #3523

Merged
merged 1 commit into from Aug 9, 2018
Merged

Update all SHOW statements #3523

merged 1 commit into from Aug 9, 2018

Conversation

jseldess
Copy link
Contributor

@jseldess jseldess commented Aug 8, 2018

Fixes #3467.
Fixes #3317.

This PR updates the primary places in the docs where we cover
SHOW statements. There may still be some out-dated examples,
but we can update those as we go.

This PR also combines SHOW CREATE TABLE, SHOW
CREATE VIEW, and SHOW CREATE SEQUENCE into a single SHOW
CREATE page, and removes the experimental status
from SHOW CONSTRAINTS.

EXPLAIN will be handled separately.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jseldess jseldess requested a review from knz August 8, 2018 21:08
Fixes #3467.
Fixes #3317.

This PR updates the primary places in the docs where we cover
SHOW statements. There may still be some out-dated examples,
but we can update those as we go.

This PR also combines SHOW CREATE TABLE, SHOW
CREATE VIEW, and SHOW CREATE SEQUENCE into a single SHOW
CREATE page, and removes the experimental status
from SHOW CONSTRAINTS.

EXPLAIN will be handled separately.
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: fantastic. I appreciate this must have been a chore, but the result is a net positive.

Reviewed 85 of 85 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@jseldess
Copy link
Contributor Author

jseldess commented Aug 9, 2018

TFTR, @knz. This work definitely makes me want to pursue #2849 and #3203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants