Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf tuning follow up #3854

Merged
merged 3 commits into from
Oct 12, 2018
Merged

Perf tuning follow up #3854

merged 3 commits into from
Oct 12, 2018

Conversation

jseldess
Copy link
Contributor

  • Port tutorial to 2.1, retesting and updating all command output
  • Calculate median instead of mean latency in Python client
  • Fix download command

Addresses part of #3541.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@lnhsingh lnhsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's mostly unchanged, I skimmed. LGTM, just one grammatical correction

Reviewed 1 of 16 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained


v2.1/performance-tuning.md, line 35 at r1 (raw file):

### Schema

You're schema and data will be based on the fictional peer-to-peer vehicle-sharing app, MovR, that was featured in the [CockroachDB 2.0 demo](https://www.youtube.com/watch?v=v2QK5VgLx6E):

"You're" -> "Your"

Copy link
Contributor Author

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR, @lhirata.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained


v2.1/performance-tuning.md, line 35 at r1 (raw file):

Previously, lhirata wrote…

"You're" -> "Your"

Done.

@jseldess jseldess merged commit 957864d into master Oct 12, 2018
@jseldess jseldess deleted the perf-tuning-follow-up branch October 12, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants