-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf tuning follow up #3854
Perf tuning follow up #3854
Conversation
771ff3a
to
02cde97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's mostly unchanged, I skimmed. LGTM, just one grammatical correction
Reviewed 1 of 16 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
v2.1/performance-tuning.md, line 35 at r1 (raw file):
### Schema You're schema and data will be based on the fictional peer-to-peer vehicle-sharing app, MovR, that was featured in the [CockroachDB 2.0 demo](https://www.youtube.com/watch?v=v2QK5VgLx6E):
"You're" -> "Your"
02cde97
to
4edbc54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR, @lhirata.
Reviewable status:
complete! 0 of 0 LGTMs obtained
v2.1/performance-tuning.md, line 35 at r1 (raw file):
Previously, lhirata wrote…
"You're" -> "Your"
Done.
Addresses part of #3541.