Fix table partitioning docs #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
…example There were numerous problems in the partition by list example: - It used only 2 datacenters, a bad pattern for CockroachDB. - In each datacenter, there was only 1 node. This made partitioning non-functional because CockroachDB won't place more than one replica of a range on a single node. - There were some bugs in the zone config settings. This PR expands the example to 3 datacenters with 3 nodes in each. It also converts the example to be runnable as a local cluster and adds an example of how to view the zone config for a partition. Fixes #4499.
jseldess
force-pushed
the
show-zone-config-for-partition
branch
from
5471106
to
4c45514
Compare
rkruze
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @Amruta-Ranade and @rkruze)
|
TFTR, @rkruze. @Amruta-Ranade, I'll wait for your copy review as well. |
Amruta-Ranade
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were numerous problems in the partition by list example:
non-functional because CockroachDB won't place more than one replica
of a range on a single node.
This PR expands the example to 3 datacenters with 3 nodes in each. It also
converts the example to be runnable as a local cluster and adds
an example of how to view the zone config for a partition.
Fixes #4499.
Separately, we'll need to re-test and refresh the partition by range example and the sub-partition example.