Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document JDBC driver cursor support #5544

Merged
merged 1 commit into from Oct 7, 2019
Merged

Document JDBC driver cursor support #5544

merged 1 commit into from Oct 7, 2019

Conversation

rmloveland
Copy link
Contributor

Fixes #5448.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/16e1ec6f796f5b537195e50de91e2ea8019fd915/

Edited pages:

@rmloveland
Copy link
Contributor Author

@mjibson I wrote a little test program to try this out based on the PGJDBC docs example. Really cool!

I think this doc update is pretty close to right, but please let me know if:

  • something is incorrect
  • we should include some additional info that is not here

maddyblue
maddyblue approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@maddyblue maddyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@rmloveland
Copy link
Contributor Author

Thanks Matt!

@rmloveland rmloveland requested review from ericharmeling and removed request for ericharmeling October 2, 2019 21:10
@rmloveland
Copy link
Contributor Author

@mjibson please take another look, I added some info about interleaved execution not being supported when setFetchSize() is set on the statement.

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/41de9d4f5b77495e3098989520fba1bd3e4f65ce/

Edited pages:

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/026099f6253fe0687b4e8f8365c7c29a7960d526/

Edited pages:

ericharmeling
ericharmeling approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mjibson)

@rmloveland rmloveland requested review from jseldess and removed request for jseldess October 7, 2019 15:24
@rmloveland rmloveland merged commit 4026a54 into master Oct 7, 2019
@rmloveland rmloveland deleted the 20191002-jdbc-streaming branch October 7, 2019 16:02
@rmloveland rmloveland mentioned this pull request Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharmeling ericharmeling ericharmeling approved these changes

@maddyblue maddyblue Awaiting requested review from maddyblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document improved streaming behavior of JDBC driver
4 participants
@rmloveland @cockroach-teamcity @maddyblue @ericharmeling