Misc. IMPORT updates #6244

lnhsingh · 2019-12-26T20:27:23Z

Edits:

Add example of DELIMITED with escaping. Closes import: add an example of DELIMITED with escaping #5895.
Add notes about DEFAULT values and how to set multiple options. Closes import: defaults are not accepted when importing #5494, Misc. Import Updates #5929.
Add strict_quotes option. Closes Document the strict_quotes IMPORT option #5851

cockroach-teamcity · 2019-12-26T20:27:29Z

This change is

cockroach-teamcity · 2019-12-26T20:30:15Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7a47f4463828f6e16b6c5e0402a6e894fda576e2/

Edited pages:

cockroach-teamcity · 2019-12-26T22:19:08Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/81f30e0c725fdffb454fd7958e07fb2e6c8ce460/

Edited pages:

cockroach-teamcity · 2019-12-26T22:44:40Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a56829ce19feacafa3f7d4d6e847e9edaca60622/

Edited pages:

lnhsingh · 2019-12-26T22:45:37Z

@dt - can you please review these misc. IMPORT updates? If you think someone else should review, lmk. Thanks!

dt

LGTM, thanks, though @spaskob might be more qualified to confirm for the DELIMITED and strict quotes stuff

spaskob

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Amruta-Ranade and @lnhsingh)

v19.2/import.md, line 735 at r3 (raw file):

I'd use something more suggestive for escaping: ''
also elsewhere

v19.2/import.md, line 761 at r3 (raw file):

If you want to escape the character used as the delimiter, use `fields_escaped_by`.
{{site.data.alerts.end}}

If you want to escape special symbols, use fields_escaped_by.

v20.1/import.md, line 749 at r3 (raw file):

{{site.data.alerts.callout_info}}
If you want to escape the character used as the delimiter, use `fields_escaped_by`.

If you want to escape the character used as the delimiter, use fields_escaped_by.

lnhsingh

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Amruta-Ranade and @spaskob)

v19.2/import.md, line 735 at r3 (raw file):

Previously, spaskob (Spas Bojanov) wrote…

'
I'd use something more suggestive for escaping: ''
also elsewhere

Done

v19.2/import.md, line 761 at r3 (raw file):

Previously, spaskob (Spas Bojanov) wrote…

If you want to escape the character used as the delimiter, use `fields_escaped_by`.
{{site.data.alerts.end}}
If you want to escape special symbols, use fields_escaped_by.

Done.

v20.1/import.md, line 749 at r3 (raw file):

Previously, spaskob (Spas Bojanov) wrote…

If you want to escape the character used as the delimiter, use fields_escaped_by.

Done.

cockroach-teamcity · 2020-01-02T16:47:02Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0e8c15b6f7a1daf75f5b29087fa02566f113019f/

Edited pages:

Amruta-Ranade · 2020-01-02T17:04:23Z

v19.2/import.md


 <a name="delimiter"></a>

 Key                 | Context&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | Value                                                                                                                             |
 --------------------+-----------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 `delimiter`            | `CSV DATA `     | The unicode character that delimits columns in your rows. **Default: `,`**.
 `comment`              | `CSV DATA `     | The unicode character that identifies rows to skip.
+`strict_quotes`        | `CSV DATA`      | Use if CSV import files have quotes (`""`) within rows to prevent multiple rows from being treated as single rows. **Off by default**


nit: Change "Off by default" to "Default: Off" to maintain consistency.

Amruta-Ranade · 2020-01-02T17:04:34Z

v20.1/import.md


 <a name="delimiter"></a>

 Key                 | Context&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | Value                                                                                                                             |
 --------------------+-----------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 `delimiter`            | `CSV DATA `     | The unicode character that delimits columns in your rows. **Default: `,`**.
 `comment`              | `CSV DATA `     | The unicode character that identifies rows to skip.
+`strict_quotes`        | `CSV DATA`      | Use if CSV import files have quotes (`""`) within rows to prevent multiple rows from being treated as single rows. **Off by default**


nit: Change "Off by default" to "Default: Off" to maintain consistency.

Amruta-Ranade · 2020-01-02T17:05:23Z

v20.1/import.md

@@ -78,14 +78,15 @@ URLs for the files you want to import must use the format shown below.  For exam

 ### Import options

-You can control the `IMPORT` process's behavior using any of the following optional key-value pairs as a `kv_option`.
+You can control the `IMPORT` process's behavior using any of the following optional key-value pairs as a `kv_option`. To set multiple import options, use a comma separated list ([see examples](#import-a-delimited-data-file)).


nit: comma separated > comma-separated

Amruta-Ranade · 2020-01-02T17:05:47Z

v19.2/import.md

@@ -78,14 +78,15 @@ URLs for the files you want to import must use the format shown below.  For exam

 ### Import options

-You can control the `IMPORT` process's behavior using any of the following optional key-value pairs as a `kv_option`.
+You can control the `IMPORT` process's behavior using any of the following optional key-value pairs as a `kv_option`. To set multiple import options, use a comma separated list ([see examples](#import-a-delimited-data-file)).


nit: comma separated > comma-separated

lnhsingh

TFTRs!

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @lnhsingh and @spaskob)

v19.2/import.md, line 81 at r4 (raw file):

Previously, Amruta-Ranade (Amruta Ranade) wrote…

nit: comma separated > comma-separated

Done.

v19.2/import.md, line 89 at r4 (raw file):

Previously, Amruta-Ranade (Amruta Ranade) wrote…

nit: Change "Off by default" to "Default: Off" to maintain consistency.

Done.

cockroach-teamcity · 2020-01-02T17:45:49Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f94d3f79dae9d6d6d1e760c8c12d67570de66e41/

Edited pages:

Add example of DELIMITED with escaping. Closes #5895. Add note about DEFAULT values and using multiple options. Closes #5494. Closes #5929. Add strict_quotes option. Closes #5851 Edits based on feedback Edits based on feedback

cockroach-teamcity · 2020-01-02T17:58:12Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f26e8c787fb7a8ac1676faf72b045570cc95ee94/

Edited pages:

lnhsingh changed the title ~~IMPORT updates~~ Misc. IMPORT updates Dec 26, 2019

lnhsingh requested a review from Amruta-Ranade December 26, 2019 22:44

lnhsingh requested a review from dt December 26, 2019 22:44

lnhsingh marked this pull request as ready for review December 26, 2019 22:46

dt approved these changes Dec 30, 2019

View reviewed changes

spaskob approved these changes Jan 2, 2020

View reviewed changes

lnhsingh commented Jan 2, 2020

View reviewed changes

Amruta-Ranade approved these changes Jan 2, 2020

View reviewed changes

lnhsingh commented Jan 2, 2020

View reviewed changes

IMPORT updates

f26e8c7

Add example of DELIMITED with escaping. Closes #5895. Add note about DEFAULT values and using multiple options. Closes #5494. Closes #5929. Add strict_quotes option. Closes #5851 Edits based on feedback Edits based on feedback

lnhsingh force-pushed the import branch from f94d3f7 to f26e8c7 Compare January 2, 2020 17:55

lnhsingh merged commit 1c9918e into master Jan 2, 2020

lnhsingh deleted the import branch January 2, 2020 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc. IMPORT updates #6244

Misc. IMPORT updates #6244

lnhsingh commented Dec 26, 2019 •

edited

Loading

cockroach-teamcity commented Dec 26, 2019

cockroach-teamcity commented Dec 26, 2019

cockroach-teamcity commented Dec 26, 2019

cockroach-teamcity commented Dec 26, 2019

lnhsingh commented Dec 26, 2019

dt left a comment

spaskob left a comment

lnhsingh left a comment

cockroach-teamcity commented Jan 2, 2020

Amruta-Ranade Jan 2, 2020

Amruta-Ranade Jan 2, 2020

Amruta-Ranade Jan 2, 2020

Amruta-Ranade Jan 2, 2020

lnhsingh left a comment

cockroach-teamcity commented Jan 2, 2020

cockroach-teamcity commented Jan 2, 2020

Misc. IMPORT updates #6244

Misc. IMPORT updates #6244

Conversation

lnhsingh commented Dec 26, 2019 • edited Loading

cockroach-teamcity commented Dec 26, 2019

cockroach-teamcity commented Dec 26, 2019

cockroach-teamcity commented Dec 26, 2019

cockroach-teamcity commented Dec 26, 2019

lnhsingh commented Dec 26, 2019

dt left a comment

Choose a reason for hiding this comment

spaskob left a comment

Choose a reason for hiding this comment

lnhsingh left a comment

Choose a reason for hiding this comment

cockroach-teamcity commented Jan 2, 2020

Amruta-Ranade Jan 2, 2020

Choose a reason for hiding this comment

Amruta-Ranade Jan 2, 2020

Choose a reason for hiding this comment

Amruta-Ranade Jan 2, 2020

Choose a reason for hiding this comment

Amruta-Ranade Jan 2, 2020

Choose a reason for hiding this comment

lnhsingh left a comment

Choose a reason for hiding this comment

cockroach-teamcity commented Jan 2, 2020

cockroach-teamcity commented Jan 2, 2020

lnhsingh commented Dec 26, 2019 •

edited

Loading