Skip to content

EXPLAIN(DISTSQL,TYPES) #7045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

EXPLAIN(DISTSQL,TYPES) #7045

merged 1 commit into from
Apr 8, 2020

Conversation

ericharmeling
Copy link
Contributor

Fixes #6447.

  • Added EXPLAIN(DISTSQL,TYPES) and example statement and diagram to EXPLAIN page.
  • Added data type description to physical plan diagram table on EXPLAIN ANALYZE page.
  • Fixed some wording in 19.1, 19.2, and 20.1 docs.
  • Updated 20.1 physical plan diagrams.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ericharmeling ericharmeling requested a review from yuzefovich April 1, 2020 21:27
@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/93c7f215bbb05073504acce4e8c783601306263c/

Edited pages:

@ericharmeling ericharmeling force-pushed the explain-distsql-types branch from 93c7f21 to c88432b Compare April 1, 2020 21:38
@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c88432b89bb6f06c0f990ad52d703032e17fc204/

Edited pages:

yuzefovich
yuzefovich reviewed Apr 1, 2020
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that on 20.1 new explain-analyze-distsql-plan.png image has the diagram of the vectorized plan. Now that we decided to preserve 19.2 behavior with regards to vectorize setting, I don't think we want the change to the diagram.

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@ericharmeling ericharmeling force-pushed the explain-distsql-types branch from c88432b to 8f6c072 Compare April 2, 2020 12:17
@ericharmeling
Copy link
Contributor Author

@yuzefovich Got it. Thanks. I updated the PR.

Re: "we decided to preserve 19.2 behavior with regards to vectorize setting", we should follow up about #7007 offline.

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8f6c0726d774c85af5f315240edbc792d1b1e9d2/

Edited pages:

@ericharmeling ericharmeling requested a review from jseldess April 2, 2020 15:47
yuzefovich
yuzefovich approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jseldess)

jseldess
jseldess approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @jseldess)

@ericharmeling ericharmeling merged commit c6b2c37 into master Apr 8, 2020
@ericharmeling ericharmeling deleted the explain-distsql-types branch April 8, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzefovich yuzefovich yuzefovich approved these changes

+1 more reviewer

@jseldess jseldess jseldess approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

execinfrapb: print out input types for EXPLAIN (DISTSQL, TYPES)
4 participants
@ericharmeling @cockroach-teamcity @yuzefovich @jseldess