Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak import paths of .proto files in errorspb #60

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

rickystewart
Copy link
Contributor

@rickystewart rickystewart commented Dec 22, 2020

This makes imports consistent both within this repository as well as in
the main CockroachDB repo. This simplifies the Bazel migration as seen
in cockroachdb/cockroach#57974.


This change is Reviewable

This makes imports consistent both within this repository as well as in
the main CockroachDB repo. This simplifies the Bazel migration as seen
in cockroachdb/cockroach#57974.
@CLAassistant
Copy link

CLAassistant commented Dec 22, 2020

CLA assistant check
All committers have signed the CLA.

@knz
Copy link
Contributor

knz commented Dec 22, 2020

LGTM thanks

@knz knz merged commit a9df884 into cockroachdb:master Dec 22, 2020
@tooolbox
Copy link
Contributor

tooolbox commented Jan 9, 2021

Out of curiosity, is this change backwards compatible, i.e. markers encoded with the old registered name will properly decode with the new registered name, and vice versa?

@rickystewart
Copy link
Contributor Author

To my knowledge, yes (and this change has been live at CockroachDB master for more than 2 weeks, so I imagine that any issues would have been noticed by now).

@knz
Copy link
Contributor

knz commented Jan 11, 2021

markers encoded with the old registered name will properly decode with the new registered name, and vice versa?

Thanks for noticing. I agree we need to explicitly check this.

I imagine that any issues would have been noticed by now).

No not necessarily. Last time we broke something in that area, we only noticed when a customer encountered a production outage after an upgrade 😭

@knz
Copy link
Contributor

knz commented Jan 11, 2021

@rickystewart also you don't need to do anything about this; I will do the investigation and fix the fallout if any.

erikgrinaker added a commit that referenced this pull request Mar 19, 2021
This is a backport of #64 and #60, which recompiles all Protobuf files
using the current gogoproto compiler in CRDB's `release-20.1` branch.
This is primarily to address the "skippy pb" vulnerability in gogoproto
Protobufs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants