Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document intended differences between WithHint and WithDetail (#114) #116

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Document intended differences between WithHint and WithDetail (#114) #116

merged 1 commit into from
Aug 10, 2023

Conversation

omarkohl
Copy link
Contributor

@omarkohl omarkohl commented Aug 3, 2023 •
edited by cockroach-dev-inf
Loading

This change is Reviewable

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RaduBerinde
Copy link
Member

This looks good to me, @knz are you ok with the "end user" / "developer" distinction?

knz
knz approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@knz knz closed this Aug 10, 2023
@knz knz reopened this Aug 10, 2023
@knz knz merged commit 1456059 into cockroachdb:master Aug 10, 2023
9 of 10 checks passed
@knz knz mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@omarkohl @cockroach-teamcity @RaduBerinde @knz