Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-cause unwrap into Sentry reporting #119

Merged

Conversation

dhartunian
Copy link
Contributor

@dhartunian dhartunian commented Aug 17, 2023

This commit modifies the causal detail collection code in report.go
to recurse through both the single-cause chain and the multi-cause
chain if applicable when collecting information for the Sentry report.


Please only review the last commit. Earlier ones are in #115 and #118.


This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM after the 1st commit is finalized.

Reviewed 11 of 11 files at r2, all commit messages.
Reviewable status: 11 of 18 files reviewed, all discussions resolved

This commit modifies the causal detail collection code in `report.go`
to recurse through both the single-cause chain and the multi-cause
chain if applicable when collecting information for the Sentry report.
@dhartunian
Copy link
Contributor Author

@knz updated.

@dhartunian dhartunian requested a review from knz August 23, 2023 15:16
@dhartunian dhartunian merged commit f13c94d into cockroachdb:go-1.20-upgrade Aug 23, 2023
3 of 4 checks passed
@dhartunian dhartunian deleted the multierror-sentry branch August 23, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants