put ip addr for localhost (127.0.0.1) into more specific field. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udnay
added
the
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the node certificate resource, the IP address for localhost is set via the field
spec.dnsNames. This seems to work in the TLS clients used within Kubernetes.But it is not correct according to the standard. There are two separate extensions to be used for this. Cert-manager handles this by differentiating between
spec.dnsNamesandspec.ipAddresses.This change simply moves the IP address "127.0.0.1" into the appropriate field.
It should not change any behaviour, only avoid potential problems with more restrictive TLS clients.