Fix endless 307 redirect if cockroachdb run in secure mode #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MrBeast, thanks for the contribution! Can you be a bit more descriptive in the commit message about what this change does? It would help with reviewing the code, as well as help anyone who is looking back at this commit in the future. Please also increment the |
|
@DuskEagle Hello! Sorry for delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a cockroachdb running in secure mode webui doesn't load with a 307 http error infinitely.
We should add
nginx.ingress.kubernetes.io/backend-protocol: HTTPSto fix this problem.related to #228