compaction: Add tests for forced compactions #868
Comments
itsbilal
added a commit
to itsbilal/pebble
that referenced
this issue
Sep 28, 2020
This change adds a test to test compaction picking logic where MarkedForCompaction = true. Previously, this boolean was completely untested, resulting in panics when Pebble was used on a previously-rocksdb store directory, as RocksDB often set that boolean to true in the manifest. Fixes cockroachdb#868.
itsbilal
added a commit
that referenced
this issue
Sep 28, 2020
This change adds a test to test compaction picking logic where MarkedForCompaction = true. Previously, this boolean was completely untested, resulting in panics when Pebble was used on a previously-rocksdb store directory, as RocksDB often set that boolean to true in the manifest. Fixes #868.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When files are marked for compaction (i.e with FileMetadata.MarkedForCompaction = true, something that RocksDB often does), and when no other higher-priority score based compaction exists, we end up generating a compaction out of the picked file(s).
The portion of code in
compactionPickerByScore.pickAutothat does this is currently untested by unit tests. This can be an issue, as it could let bugs in that logic go ignored until they get caught by higher level tests or roachtests in Cockroach. An example of such a recent bug would be cockroachdb/cockroach#53121 .Changing
testdata/compaction_picker_target_levelto allow for specifying sstables marked for compactions should be a fairly straightforward way to test this logic.The text was updated successfully, but these errors were encountered: