staging: Rename database objects #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the default staging database name from _cdc_sink to _replicator. The provider function for the staging database name is updated to look for the legacy name and use that instead. Various references to the _cdc_sink database have been updated to reflect the new name. Existing documents in the migrations directory are not updated, since they are historical documents only. The default name for the DLQ table has been adjusted without automatic backward-compatibility, since this has only been used in limited testing scenarios.
28 tasks
sravotto
approved these changes
May 8, 2024
There was a problem hiding this comment.
Reviewed 10 of 16 files at r1, all commit messages.
Reviewable status: 10 of 16 files reviewed, all discussions resolved (waiting on @BramGruneir)
BramGruneir
approved these changes
May 8, 2024
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bobvawter)
internal/sinktest/base/provider.go line 111 at r1 (raw file):
SourcePool *types.SourcePool // Access to user-data tables and changefeed creation. SourceSchema sinktest.SourceSchema // A container for tables within SourcePool. StagingPool *types.StagingPool // Access to _replicator database.
Why not just call these staging instead of _replicator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the default staging database name from _cdc_sink to _replicator. The provider function for the staging database name is updated to look for the legacy name and use that instead.
Various references to the _cdc_sink database have been updated to reflect the new name. Existing documents in the migrations directory are not updated, since they are historical documents only.
The default name for the DLQ table has been adjusted without automatic backward-compatibility, since this has only been used in limited testing scenarios.
This change is