Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retrieving hidden columns during inspection #173

Closed
edgarrmondragon opened this issue Dec 7, 2021 · 3 comments · Fixed by #177
Closed

Support retrieving hidden columns during inspection #173

edgarrmondragon opened this issue Dec 7, 2021 · 3 comments · Fixed by #177

Comments

@edgarrmondragon
Copy link

edgarrmondragon commented Dec 7, 2021

For ELT applications extracting data from CockroachDB, it'd be good to get the rowid column during inspection for tables that don't declare an explicit primary key.

The current behavior of the dialect for CockroachDB>=19.1 is to filter the column out with WHERE ... AND NOT is_hidden::bool.

Perhaps popping a boolean argument include_hidden from kw in CockroachDBDialect.get_columns(self, conn, table_name, schema=None, **kw) could be used to decide if hidden columns are to be inspected.

@kernfeld-cockroach
Copy link
Contributor

@gordthompson do you think this would be a useful feature for SQLAlchemy users? If it looks useful, could you work on this when you have some free time?

@gordthompson
Copy link
Collaborator

Hi, Paul. Sure, I can take a look at implementing this.

@edgarrmondragon
Copy link
Author

Thank you @gordthompson !

gordthompson added a commit to gordthompson/sqlalchemy-cockroachdb that referenced this issue Dec 29, 2021
rafiss pushed a commit that referenced this issue Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants