Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs check #206

Merged
merged 1 commit into from
May 3, 2024
Merged

Add docs check #206

merged 1 commit into from
May 3, 2024

Conversation

fantapop
Copy link
Collaborator

@fantapop fantapop commented May 2, 2024

Add a github workflow that runs make generate and fails if there are any changes.

example failure:

Screenshot 2024-05-02 at 5 23 13 PM Screenshot 2024-05-02 at 5 23 37 PM

@fantapop fantapop force-pushed the add-docs-check branch 7 times, most recently from 9b6a77a to 0f15485 Compare May 3, 2024 00:19
@fantapop fantapop requested a review from rgcase May 3, 2024 00:27
@fantapop fantapop marked this pull request as ready for review May 3, 2024 00:27
Copy link
Contributor

@rgcase rgcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is great LGTM

@fantapop fantapop merged commit 7a41c89 into main May 3, 2024
4 checks passed
@fantapop fantapop deleted the add-docs-check branch May 3, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants