eslint-config, ui-components: add stricter rules to eslint config #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been adding stricter rules to the eslint config in the managed-service repo. Now that the eslint version has been updated, we can update the rules as well. There was one naming rule violation in the ui-components package that is now ignored because the we are passing a component in as a prop. The casing is correct.
|
TFTR! So fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been adding stricter rules to the eslint config in the
managed-service repo. Now that the eslint version has been updated, we
can update the rules as well.
There was one naming rule violation in the ui-components package that
is now ignored because the we are passing a component in as a prop. The
casing is correct.
I moved everything below https://github.com/cockroachlabs/managed-service/blob/master/console/.eslintrc.json#L6.