Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-components] Use color tokens #62

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

laurenbarker
Copy link
Collaborator

@laurenbarker laurenbarker commented May 29, 2020

ui-components // Use tokens

Based on #54.

The input and tooltip component's tokens haven't been compared to current mocks or added to the tokens package since they were added after this PR was put up but the stylesheets have been updated to use the core color tokens.

Visual changes

Colors for badges were updated to match latest mocks:

2020-06-26 14 30 42

Checklist

  • I have written or updated test for the changes I made (N/A)
  • I have updated the README of the package I'm working in to reflect my changes (N/A)
  • I have added or updated Storybook if appropriate for my changes (N/A)

Copy link
Contributor

@j-low j-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good-- exciting stuff!

@laurenbarker laurenbarker merged commit cbc7f12 into cockroachdb:master Jun 29, 2020
Copy link
Contributor

@nathanstilwell nathanstilwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants